Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Cleanup performance_test.yml code #1406

Merged
merged 4 commits into from
Sep 12, 2022
Merged

CI: Cleanup performance_test.yml code #1406

merged 4 commits into from
Sep 12, 2022

Conversation

esquith
Copy link
Contributor

@esquith esquith commented Sep 9, 2022 •
edited
Loading

Before contributing, please read our contributing guidelines and code of conduct.

Overview

Cleaning up performance_tests.yml

#1398

Submitter Checklist:

  • Include a link to the related GitHub issue, if applicable
  • Include a security review link, if applicable

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Sep 9, 2022
@fallwith
Copy link
Contributor

fallwith commented Sep 11, 2022 •
edited
Loading

Hi @esquith. Thank you very much for your contribution!

I have one change I would like for you make when you get a chance. I'd like the YAML file itself to go back to the original name performance_tests.yml, and then have the two path: ./test/performance/performance_tests.txt lines inside the YAML be changed to path: ./test/performance/performance_results.txt. I think it'll be better if the filename itself indicates that the contents are related to tests and then the paths specified inside indicate that they contain results.

After that change is made, we'll just need you to sign the project's contributor license agreement and one of us on the team will be able to get this one merged in.

@esquith
Copy link
Contributor Author

esquith commented Sep 11, 2022

@fallwith Thanks James, that is now done

fallwith
fallwith approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@fallwith fallwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this issue, your help is much appreciated. And welcome to our contributors list! Your efforts are now a part of New Relic's open source offerings.

@fallwith fallwith merged commit 51fc036 into newrelic:dev Sep 12, 2022
@fallwith fallwith mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallwith fallwith fallwith approved these changes

Assignees
No one assigned
Labels
community To tag external issues and PRs submitted by the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esquith @CLAassistant @fallwith